Repository navigation
Conversation
Slicing a variadic tuple with literal start and stop on the same side (both non-negative or both negative) where start >= stop (or start <= stop with a negative step) always gives an empty tuple, whatever the tuple's length. TupleType.slice didn't handle this when the start fell after the unpack, so mypy reported "Ambiguous slice of a variadic tuple" and inferred Any. Return tuple[()] in that case instead.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: scipy-stubs (https://github.com/scipy/scipy-stubs)
+ tests/misc/test_submodules_empty.pyi:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slicing a variadic tuple where start and stop count from the same end and start >= stop gives an empty tuple at runtime, whatever the tuple's length. mypy reports an error instead:
TupleType.sliceonly covers a few prefix/suffix layouts for variadic tuples. Whenbeginis past the unpack, it falls through to thereturn Nonebranch, and the caller reports the ambiguous-slice error. Fixed tuples don't have this problem because they just use Python's own slicing.If
beginandendare both non-negative or both negative, thenbegin >= end(step positive or omitted) orbegin <= end(step negative) means the slice is empty for every possible length, because Python clamps both bounds the same way. The fix handles that case first and returnstuple[()]. All other cases behave as before; the test checks thaty[1:5]andy[-2:-5:-1]still report the ambiguous-slice error.Test:
testVariadicTupleEmptySliceincheck-typevar-tuple.test. It fails on master.