Support --shadow-file with --native-parser#21623
Open
JukkaL wants to merge 1 commit into
Open
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
ilevkivskyi
reviewed
Jun 18, 2026
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
LG, but there are couple problems in tests.
| == Return code: 0 | ||
|
|
||
| [case testShadowFileWithNativeParserParallel] | ||
| # cmd: mypy --native-parser --shadow-file a.py a_shadow.py main.py a.py b.py |
Member
There was a problem hiding this comment.
The test name says Parallel but the command line doesn't specify --num-workers. You should add e.g. --num-workers=4.
| reveal_type(x) | ||
| [out] | ||
| a.py:2: note: Revealed type is "str" | ||
| == Return code: 0 |
Member
There was a problem hiding this comment.
I think it is worth adding an incremental test for --shadow-file in parallel mode as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.