Skip to content

[mypyc] Report an error if an acyclic class inherits from non-acyclic #21227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
p-sawicki merged 3 commits into from
Apr 15, 2026
Merged

[mypyc] Report an error if an acyclic class inherits from non-acyclic #21227

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bce3e72
[mypyc] Report an error if an acyclic class inherits from non-acyclic
p-sawicki Apr 14, 2026
7daeba7
Move test to new file
p-sawicki Apr 14, 2026
dd3b65e
Add more test cases
p-sawicki Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move test to new file
  • Loading branch information
@p-sawicki
p-sawicki committed Apr 14, 2026
commit 7daeba7ce27fd2b4e2a00d859f3f90e5970a35fc
7 changes: 0 additions & 7 deletions mypyc/test-data/irbuild-classes.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2163,13 +2163,6 @@ class BadDerived(NonAcyclicBase): # E: "acyclic" can't be used in a class that
class BadGeneric(Generic[T]): # E: "acyclic" can't be used in a class that inherits from non-acyclic type "typing.Generic"
Copy link
Copy Markdown
Collaborator

@JukkaL JukkaL Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about testing traits and non-native classes as bases (fine to do this in a follow-up PR)?

pass

[case testAcyclicGenericIsRejected_python3_12]
from mypy_extensions import mypyc_attr

@mypyc_attr(acyclic=True)
class BadGeneric[T]: # E: "acyclic" can't be used in a class that inherits from non-acyclic type "typing.Generic"
pass

[case testUnsupportedGetAttr]
from mypy_extensions import mypyc_attr

Expand Down
6 changes: 6 additions & 0 deletions mypyc/test-data/irbuild-python312.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
[case testAcyclicGenericIsRejected_python3_12]
from mypy_extensions import mypyc_attr

@mypyc_attr(acyclic=True)
class BadGeneric[T]: # E: "acyclic" can't be used in a class that inherits from non-acyclic type "typing.Generic"
pass
3 changes: 3 additions & 0 deletions mypyc/test/test_irbuild.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@
"irbuild-match.test",
]

if sys.version_info >= (3, 12):
files.append("irbuild-python312.test")

if sys.version_info >= (3, 14):
files.append("irbuild-python314.test")

Expand Down
Loading