Skip to content

[mypyc] Fix memory leak on property setter call #21095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
p-sawicki merged 9 commits into from
Mar 24, 2026
+181 −6
Merged

[mypyc] Fix memory leak on property setter call #21095

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f1b5d67
Add decref
p-sawicki Mar 23, 2026
6482508
Update test
p-sawicki Mar 23, 2026
bea3c66
Add comment
p-sawicki Mar 23, 2026
e548a82
Check if passed value is refcounted
p-sawicki Mar 23, 2026
52d4a58
Don't mark prop set source as stolen in SetAttr
p-sawicki Mar 24, 2026
1990b6d
Disable test on 32-bit python
p-sawicki Mar 24, 2026
26bd874
Use is_propset in emitfunc
p-sawicki Mar 24, 2026
d8e8a11
Fix determination of propset in multimodule compilation
p-sawicki Mar 24, 2026
b73f03a
Use is_propset in emitfunc again
p-sawicki Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use is_propset in emitfunc
  • Loading branch information
@p-sawicki
p-sawicki committed Mar 24, 2026
commit 26bd874bdf79c5fc06791c3c05f029349d3d7fa4
2 changes: 1 addition & 1 deletion mypyc/codegen/emitfunc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ def visit_set_attr(self, op: SetAttr) -> None:
rtype = op.class_type
cl = rtype.class_ir
attr_rtype, decl_cl = cl.attr_details(op.attr)
if cl.get_method(op.attr):
if op.is_propset:
# Again, use vtable access for properties...
assert not op.is_init and op.error_kind == ERR_FALSE, "%s %d %d %s" % (
op.attr,
Expand Down
Loading