Conversation
|
I'll keep this PR open for a while, in case somebody else wants to review the changes, but we will merge this once this is needed to unblock the 1.19 release. |
ilevkivskyi
left a comment
There was a problem hiding this comment.
LG, added some optional comments.
| - Add tool to convert binary cache files to JSON (Jukka Lehtosalo, PR [20071](https://github.com/python/mypy/pull/20071)) | ||
| - Use more efficient serialization format for long integers in cache files (Jukka Lehtosalo, PR [20151](https://github.com/python/mypy/pull/20151)) | ||
| - More robust packing of flats in FF cache (Ivan Levkivskyi, PR [20150](https://github.com/python/mypy/pull/20150)) | ||
| - More robust packing of flats in fixed-format cache (Ivan Levkivskyi, PR [20150](https://github.com/python/mypy/pull/20150)) |
There was a problem hiding this comment.
I guess it should be floats, not flats.
| ### Fixed‑Format Cache Improvements | ||
|
|
||
| Mypy uses a cache by default to speed up incremental runs by reusing partial results | ||
| from earlier runs. Mypy 1.18 added a new binary, fixed-format cache representation as |
There was a problem hiding this comment.
Not sure about the comma here, AI says no comma is needed for cumulative adjectives (whatever it means).
| - Support deleting attributes in `__setattr__` wrapper (Piotr Sawicki, PR [19997](https://github.com/python/mypy/pull/19997)) | ||
|
|
||
| Mypyc now has partial support for `__getattr__`, `__setattr__` and | ||
| `__delattr__` methods in native classes. |
There was a problem hiding this comment.
Assuming we are going forward with #20302 instead of a revert, we should probably also mention __new__().
There was a problem hiding this comment.
Yeah, I'll add it before merging depending on the final outcome.
| from earlier runs. Mypy 1.18 added a new binary, fixed-format cache representation as | ||
| an experimental feature. The feature is no longer experimental, and we are planning | ||
| to enable it by default in a future mypy release (possibly 1.20), since it's faster | ||
| and uses less space than the original, JSON-based cache format. |
There was a problem hiding this comment.
Maybe also remind how to enable the FF cache.
The first draft was added in #20296.
The first draft was added in #20296.