[mypyc] Avoid uses of _PyObject_CallMethodOneArg on 3.13#17526
Merged
Conversation
It's no longer available in CPython 3.13 betas. This fixes some dict primitives on 3.13. Work on mypyc/mypyc#1056.
cdce8p
reviewed
Jul 14, 2024
Comment on lines
401
to
403
| _PyObject_CallMethodIdObjArgs((self), (name), NULL) | ||
| #define _PyObject_CallMethodIdOneArg(self, name, arg) \ | ||
| _PyObject_CallMethodIdObjArgs((self), (name), (arg), NULL) |
Collaborator
There was a problem hiding this comment.
Maybe we should remove _PyObject_CallMethodIdNoArg and _PyObject_CallMethodIdOneArg here. _PyObject_CallMethodIdObjArgs is no longer exported in Python 3.13.
Collaborator
There was a problem hiding this comment.
Never mind, those are only used for < 3.9 anyway.
hauntsaninja
approved these changes
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's no longer available in CPython 3.13 betas.
This fixes some dict primitives on 3.13.
Work on mypyc/mypyc#1056.