Skip to content

Enables the narrowing of variable types when checking a variable is "in" a collection. #17344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 7 commits into from
Jul 24, 2024
Merged

Enables the narrowing of variable types when checking a variable is "in" a collection. #17344

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fd85e87
Enable narrowing types using the "in" operator
Jordandev678 Jun 7, 2024
3783f1d
Add test case from #3229
Jordandev678 Jun 7, 2024
dae707d
Add list to narrowing.pyi for testTypeNarrowingStringInList
Jordandev678 Jun 7, 2024
0c10969
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 7, 2024
800741a
Don't update if_map if item_type == collection_item_type
Jordandev678 Jun 8, 2024
8c86ce1
Merge branch 'master' into innarrowing
Jordandev678 Jun 8, 2024
0bb5689
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test case from #3229
  • Loading branch information
@Jordandev678
Jordandev678 committed Jun 7, 2024
commit 3783f1d07d253425b4d8090e56656688433a696b
10 changes: 10 additions & 0 deletions test-data/unit/check-narrowing.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2211,4 +2211,14 @@ if x not in typ:
else:
reveal_type(x) # N: Revealed type is "Union[Literal['a'], Literal['b']]"
[builtins fixtures/narrowing.pyi]
[typing fixtures/typing-medium.pyi]

[case testTypeNarrowingUnionStringFloat]
from typing import Union
def foobar(foo: Union[str, float]):
if foo in ['a', 'b']:
reveal_type(foo) # N: Revealed type is "builtins.str"
else:
reveal_type(foo) # N: Revealed type is "Union[builtins.str, builtins.float]"
[builtins fixtures/primitives.pyi]
[typing fixtures/typing-medium.pyi]