Fix stubtest's tests to work with the latest typing_extensions release#16588
Merged
Merged
Conversation
ikonst
approved these changes
Nov 29, 2023
Member
Author
|
(I've verified locally that this fixes the stubtest CI errors we saw in python/typing_extensions#307) |
JelleZijlstra
approved these changes
Nov 29, 2023
Contributor
|
Could this be considered for 1.7.2, @hauntsaninja ? |
Member
Author
It doesn't need to be; all we need to get the daily test passing at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stubtest's tests will start failing when
typing_extensions==4.9.0comes out, due to some newClassVars ontyping_extensions.TypedDict. This PR fixes that.Fixes python/typing_extensions#309