Skip to content

gh-99535: Add test for inheritance of annotations and update documentation #99990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 6 commits into from
Dec 24, 2022
Merged

gh-99535: Add test for inheritance of annotations and update documentation #99990

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0787052
Add test for inheritance of annotations and update documentation
MonadChains Dec 4, 2022
f5c7cee
Add multiple inheritance case to test
MonadChains Dec 4, 2022
671a262
Add note to get_type_hints
MonadChains Dec 6, 2022
24a118e
Add additional test
MonadChains Dec 7, 2022
67a0175
Rework annotations.rst addition
MonadChains Dec 18, 2022
ad64aab
Improve get_type_hints entry
MonadChains Dec 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add test for inheritance of annotations and update documentation
  • Loading branch information
@MonadChains
MonadChains committed Dec 4, 2022
commit 0787052d9fda0d54173f7c2cb6b6451def193ff6
4 changes: 4 additions & 0 deletions Doc/howto/annotations.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ Accessing The Annotations Dict Of An Object In Python 3.10 And Newer
newer is to call :func:`getattr` with three arguments,
for example ``getattr(o, '__annotations__', None)``.

Starting from Python 3.10, accessing the annotations
of a class will not give anymore the ones of its base
classes.
Comment thread
MonadChains marked this conversation as resolved.
Outdated


Accessing The Annotations Dict Of An Object In Python 3.9 And Older
===================================================================
Expand Down
13 changes: 13 additions & 0 deletions Lib/test/test_grammar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,19 @@ class Cbad2(C):
x: int
x.y: list = []

def test_annotations_inheritance(self):
# Check that annotations are not inherited by derived classes
class A:
attr: int
class B(A):
pass
class C(A):
Comment thread
MonadChains marked this conversation as resolved.
attr: str
self.assertEqual(A.__annotations__, {"attr": int})
self.assertEqual(B.__annotations__, {})
self.assertEqual(C.__annotations__, {"attr" : str})
Comment thread
MonadChains marked this conversation as resolved.


def test_var_annot_metaclass_semantics(self):
class CMeta(type):
@classmethod
Expand Down