Skip to content

gh-92216: improve performance of hasattr for type objects #99979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 9 commits into from
Dec 23, 2022
Merged

gh-92216: improve performance of hasattr for type objects #99979

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1ef4b4b
improve performance of hasattr for type objects
eendebakpt Dec 4, 2022
8f0f472
📜🤖 Added by blurb_it.
blurb-it[bot] Dec 4, 2022
5322a2a
Merge branch 'main' into type_hasattr
eendebakpt Dec 13, 2022
c689b92
Merge branch 'main' into type_hasattr
eendebakpt Dec 15, 2022
9157e1b
fix merge conflict
eendebakpt Dec 18, 2022
2c91bb4
Merge branch 'main' into type_hasattr
eendebakpt Dec 18, 2022
fa39a8e
address review comments
eendebakpt Dec 23, 2022
ed3e023
add docstring
eendebakpt Dec 23, 2022
1d15a74
update docstring
eendebakpt Dec 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix merge conflict
  • Loading branch information
@eendebakpt
eendebakpt committed Dec 18, 2022
commit 9157e1b77423761662862665a5e1579c3365ab17
19 changes: 0 additions & 19 deletions Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4218,25 +4218,6 @@ _PyType_LookupId(PyTypeObject *type, _Py_Identifier *name)
return _PyType_Lookup(type, oname);
}


/* Check if the "readied" PyUnicode name
is a double-underscore special name. */
static int
is_dunder_name(PyObject *name)
{
Py_ssize_t length = PyUnicode_GET_LENGTH(name);
int kind = PyUnicode_KIND(name);
/* Special names contain at least "__x__" and are always ASCII. */
if (length > 4 && kind == PyUnicode_1BYTE_KIND) {
const Py_UCS1 *characters = PyUnicode_1BYTE_DATA(name);
return (
((characters[length-2] == '_') && (characters[length-1] == '_')) &&
((characters[0] == '_') && (characters[1] == '_'))
);
}
return 0;
}

/* This is similar to PyObject_GenericGetAttr(),
but uses _PyType_Lookup() instead of just looking in type->tp_dict. */
PyObject *
Expand Down