Skip to content

gh-99824: Document that sqlite3.connect implicitly open a transaction if autocommit=False #99825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 8 commits into from
Nov 30, 2022
Merged

gh-99824: Document that sqlite3.connect implicitly open a transaction if autocommit=False #99825

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
86b8244
Document sqlite3.connect() as implicitly opening transactions in the …
geryogam Nov 21, 2022
c3963f4
Document sqlite3.connect() as implicitly opening transactions in the …
geryogam Nov 28, 2022
9cbd2c6
Revert "Document sqlite3.connect() as implicitly opening transactions…
geryogam Nov 28, 2022
a9273c6
Apply Erlend’s change suggestion
geryogam Nov 28, 2022
452c52a
Move and extend the implicit transaction opening sentence for connect()
geryogam Nov 29, 2022
d866e90
Add a similar descriptive sentence for the isolation_level parameter
geryogam Nov 29, 2022
0d15229
Apply CAM’s suggested change
geryogam Nov 30, 2022
7fd8cb7
Merge branch 'main' into sqlite3/implicit-transactions
erlend-aasland Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Document sqlite3.connect() as implicitly opening transactions… 
… in the new PEP-249 manual commit mode"

This reverts commit 86b8244.
  • Loading branch information
@geryogam
geryogam committed Nov 28, 2022
commit 9cbd2c675ff420dbf6bdc59e16c87ac9667b9613
7 changes: 4 additions & 3 deletions Doc/library/sqlite3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2468,9 +2468,10 @@ It is suggested to set *autocommit* to ``False``,
which implies :pep:`249`-compliant transaction control.
This means:

* :func:`connect`, :meth:`Connection.commit`, and :meth:`Connection.rollback`
implicitly open a new transaction to ensure that a transaction is always
open.
* :mod:`!sqlite3` ensures that a transaction is always open,
so :meth:`Connection.commit` and :meth:`Connection.rollback`
will implicitly open a new transaction immediately after closing
the pending one.
:mod:`!sqlite3` uses ``BEGIN DEFERRED`` statements when opening transactions.
* Transactions should be committed explicitly using :meth:`!commit`.
* Transactions should be rolled back explicitly using :meth:`!rollback`.
Expand Down