Skip to content

gh-99576: Fix cookiejar file that was not truncated for some classes #99616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 2 commits into from
Dec 20, 2022
Merged

gh-99576: Fix cookiejar file that was not truncated for some classes #99616

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26ab026
gh-99576: Fix cookiejar file that was not truncated for some classes
sobolevn Nov 20, 2022
7715d92
Fix crimes against bracket pair formatting
ambv Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix crimes against bracket pair formatting
  • Loading branch information
@ambv
ambv committed Dec 20, 2022
commit 7715d924bc6fca55b4cd1eee870690ccfadec3ed
10 changes: 6 additions & 4 deletions Lib/http/cookiejar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1891,8 +1891,9 @@ def save(self, filename=None, ignore_discard=False, ignore_expires=False):
else: raise ValueError(MISSING_FILENAME_TEXT)

with os.fdopen(
os.open(filename, os.O_CREAT | os.O_WRONLY | os.O_TRUNC, 0o600,
), 'w') as f:
os.open(filename, os.O_CREAT | os.O_WRONLY | os.O_TRUNC, 0o600),
'w',
) as f:
# There really isn't an LWP Cookies 2.0 format, but this indicates
# that there is extra information in here (domain_dot and
# port_spec) while still being compatible with libwww-perl, I hope.
Expand Down Expand Up @@ -2089,8 +2090,9 @@ def save(self, filename=None, ignore_discard=False, ignore_expires=False):
else: raise ValueError(MISSING_FILENAME_TEXT)

with os.fdopen(
os.open(filename, os.O_CREAT | os.O_WRONLY | os.O_TRUNC, 0o600,
), 'w') as f:
os.open(filename, os.O_CREAT | os.O_WRONLY | os.O_TRUNC, 0o600),
'w',
) as f:
f.write(NETSCAPE_HEADER_TEXT)
now = time.time()
for cookie in self:
Expand Down