Skip to content

gh-100519: simplification to eff_request_host in cookiejar.py #99588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 4 commits into from
Dec 25, 2022
Merged

gh-100519: simplification to eff_request_host in cookiejar.py #99588

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
33c0ea6
small simplification to `eff_request_host` in cookiejar.py
glyph Jan 29, 2022
51d53dc
Merge branch 'main' into patch-1
glyph Nov 18, 2022
a431fb6
news
hauntsaninja Dec 24, 2022
e1506dd
Merge branch 'main' into patch-1
JelleZijlstra Dec 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
small simplification to eff_request_host in cookiejar.py 
`IPV4_RE` includes a `.`, and the `.find(".") == -1` included here is already testing to make sure there's no dot, so this part of the expression is tautological. Instead use more modern `in` syntax to make it clear what the check is doing here
  • Loading branch information
@glyph
glyph authored Jan 29, 2022
commit 33c0ea6c721a3f9f623a4e8b26165d79a0025f35
2 changes: 1 addition & 1 deletion Lib/http/cookiejar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,7 +641,7 @@ def eff_request_host(request):

"""
erhn = req_host = request_host(request)
if req_host.find(".") == -1 and not IPV4_RE.search(req_host):
if "." not in req_host:
erhn = req_host + ".local"
return req_host, erhn

Expand Down