bpo-35019: Allow ipaddres.IPv4/v6Address in asyncio.create_server#9956
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
|
Thanks for the PR @DamlaAltun . I think this deserves a NEWS entry since this is an enhancement over the existing API adding support for IPv4 and IPv6 objects. You can find more about NEWS entry at https://devguide.python.org/committing/#what-s-new-and-news-entries . You can use blurb to add one. |
|
Thanks, i'll add a news entry. |
asvetlov
left a comment
There was a problem hiding this comment.
I think we should implement something like os.PathLike / __fspath__ but for IP addresses.
Support it in socket module instead of adding a partial support for asyncio (connect API doesn't support ip addresses after the patch is applied for example)
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
|
I think it is big enough for posting to Python-ideas and writing a PEP. If it is possible i want to work on that.
|
|
@DamlaAltun sounds good! I think we should start from worikng on implementation first and after getting it done we can propose a PEP. Please keep me in the loop and don't afraid to ask for any help. I'm closing the PR for sake of more generalized solution. |
Allow ipaddres.IPv4/v6Address in asyncio.create_server
bpo-35019 - Checked the host for if is instance of IPv4/v6Address and if it is a instance of that get the value with with exploded.
https://bugs.python.org/issue35019