Skip to content

[3.11] gh-98940: Fix Mac/Extras.install.py File filter bug (GH-98943) #99528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 1 commit into from
Nov 16, 2022
Merged

[3.11] gh-98940: Fix Mac/Extras.install.py File filter bug (GH-98943) #99528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-98940: Fix Mac/Extras.install.py File filter bug (GH-98943) 
Slightly simplify the script and fix a case issue in the name of ``.DS_Store`` files.

(cherry picked from commit ea88d34)

Co-authored-by: zhangbo <zhangbo2012@outlook.com>
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
  • Loading branch information
@zhangbo2012 @sobolevn @miss-islington
2 people authored and miss-islington committed Nov 16, 2022
commit 148369e7b6eaeface67543c9983db02dc2ee5a7a
7 changes: 3 additions & 4 deletions Mac/Extras.install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,9 @@
debug = 0

def isclean(name):
if name == 'CVS': return 0
if name == '.cvsignore': return 0
if name == '.DS_store': return 0
if name == '.svn': return 0
if name in ('CVS', '.cvsignore', '.svn'):
return 0
if name.lower() == '.ds_store': return 0
if name.endswith('~'): return 0
if name.endswith('.BAK'): return 0
if name.endswith('.pyc'): return 0
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/macOS/2022-11-01-10-32-23.gh-issue-98940.W3YzC_.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix ``Mac/Extras.install.py`` file filter bug.