Skip to content

gh-99509: Add __class_getitem__ to multiprocessing.Queue #99511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 1 commit into from
Dec 27, 2022
Merged

gh-99509: Add __class_getitem__ to multiprocessing.Queue #99511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-99509: Add __class_getitem__ to multiprocessing.Qeueu
  • Loading branch information
@sobolevn
sobolevn committed Nov 15, 2022
commit 74dd0c84ddb6eabdd2a158a4197550d2fdff129e
2 changes: 2 additions & 0 deletions Lib/multiprocessing/queues.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,8 @@ def _on_queue_feeder_error(e, obj):
import traceback
traceback.print_exc()

__class_getitem__ = classmethod(types.GenericAlias)


_sentinel = object()

Expand Down
7 changes: 6 additions & 1 deletion Lib/test/test_genericalias.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,15 @@
from multiprocessing.managers import ValueProxy
from multiprocessing.pool import ApplyResult
from multiprocessing.queues import SimpleQueue as MPSimpleQueue
from multiprocessing.queues import Queue as MPQueue
from multiprocessing.queues import JoinableQueue as MPJoinableQueue
except ImportError:
# _multiprocessing module is optional
ValueProxy = None
ApplyResult = None
MPSimpleQueue = None
MPQueue = None
MPJoinableQueue = None
try:
from multiprocessing.shared_memory import ShareableList
except ImportError:
Expand Down Expand Up @@ -130,7 +134,8 @@ class BaseTest(unittest.TestCase):
if ctypes is not None:
generic_types.extend((ctypes.Array, ctypes.LibraryLoader))
if ValueProxy is not None:
generic_types.extend((ValueProxy, ApplyResult, MPSimpleQueue))
generic_types.extend((ValueProxy, ApplyResult,
MPSimpleQueue, MPQueue, MPJoinableQueue))

def test_subscriptable(self):
for t in self.generic_types:
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2022-11-15-18-45-01.gh-issue-99509.FLK0xU.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add :pep:`585` support for :class:`multiprocessing.queues.Queue`.