Skip to content

gh-81057: Move Global Variables Holding Objects to _PyRuntimeState. #99487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 11 commits into from
Nov 14, 2022
Merged

gh-81057: Move Global Variables Holding Objects to _PyRuntimeState. #99487

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
44a90b4
Move objreduce to PyInterpreterState.
ericsnowcurrently Nov 11, 2022
f748f82
Move the cached values in resolve_slotdups() to PyInterpreterState.
ericsnowcurrently Nov 11, 2022
8350dd1
Move next_version_tag to _PyRuntimeState.
ericsnowcurrently Nov 11, 2022
526d2da
Move _str_replace_inf to _PyRuntimeState.
ericsnowcurrently Nov 11, 2022
c68d016
Drop some globals from the whitelist.
ericsnowcurrently Nov 11, 2022
d5d6c2d
Move a whitelist entry to the right section.
ericsnowcurrently Nov 11, 2022
9f15148
Move some test-related globals to the ignored list.
ericsnowcurrently Nov 11, 2022
84c701d
Drop a missing global from the whitelist.
ericsnowcurrently Nov 11, 2022
b5a1f43
Drop another.
ericsnowcurrently Nov 11, 2022
4174479
Move a global from the whitelist to the ingored list.
ericsnowcurrently Nov 11, 2022
1275901
Move a whitelist entry to the right section.
ericsnowcurrently Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move some test-related globals to the ignored list.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Nov 14, 2022
commit 9f1514829aa0685e8761ef98ad13d65c49823f2e
2 changes: 0 additions & 2 deletions Tools/c-analyzer/cpython/globals-to-fix.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,8 +506,6 @@ Modules/_io/winconsoleio.c - _PyWindowsConsoleIO_Type -
# initialized once
Modules/_functoolsmodule.c - kwd_mark -
Modules/_io/_iomodule.c - _PyIO_empty_bytes -
Modules/_testcapi/heaptype.c - _testcapimodule -
Modules/_testcapi/unicode.c - _testcapimodule -

# state
Modules/faulthandler.c - fatal_error -
Expand Down
2 changes: 2 additions & 0 deletions Tools/c-analyzer/cpython/ignored.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,8 @@ Modules/_testbuffer.c ndarray_memoryview_from_buffer strides -
Modules/_testbuffer.c ndarray_memoryview_from_buffer suboffsets -
Modules/_testbuffer.c ndarray_push kwlist -
Modules/_testbuffer.c staticarray_init kwlist -
Modules/_testcapi/heaptype.c - _testcapimodule -
Modules/_testcapi/unicode.c - _testcapimodule -
Modules/_testcapimodule.c - ContainerNoGC_members -
Modules/_testcapimodule.c - ContainerNoGC_type -
Modules/_testcapimodule.c - FmData -
Expand Down