Skip to content

gh-81057: Move the Extension Modules Cache to _PyRuntimeState #99355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 6 commits into from
Nov 11, 2022
Merged

gh-81057: Move the Extension Modules Cache to _PyRuntimeState #99355

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e21e012
Add a comment describing PyInterpreterState.modules_by_index.
ericsnowcurrently Nov 10, 2022
453ca0e
Add comments describing the PyModuleDef_Base fields.
ericsnowcurrently Nov 10, 2022
3b93ab9
Add _PyRuntimeState.imports.extensions.
ericsnowcurrently Nov 10, 2022
b3e3f45
Switch to _extensions_cache_*().
ericsnowcurrently Nov 10, 2022
1663bfc
Add _PyRuntimeState.imports.last_module_index.
ericsnowcurrently Nov 10, 2022
67dff4d
Refer to the modules_by_index comment.
ericsnowcurrently Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comments describing the PyModuleDef_Base fields.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Nov 10, 2022
commit 453ca0e102e7aef42ec608deddc7e526a159ed9a
13 changes: 13 additions & 0 deletions Include/moduleobject.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,21 @@ PyAPI_DATA(PyTypeObject) PyModuleDef_Type;

typedef struct PyModuleDef_Base {
PyObject_HEAD
/* The function used to re-initialize the module.
This is only set for legacy (single-phase init) extension modules
and only used for those that support multiple initializations
(m_size >= 0).
It is set by _PyImport_LoadDynamicModuleWithSpec()
and _imp.create_builtin(). */
PyObject* (*m_init)(void);
/* The module's index into its interpreter's modules_by_index cache.
This is set for all extension modules but only used for legacy ones.
It is set by PyModuleDef_Init(). */
Py_ssize_t m_index;
/* A copy of the module's __dict__ after the first time it was loaded.
This is only set/used for legacy modules that do not support
multiple initializations.
It is set by _PyImport_FixupExtensionObject(). */
PyObject* m_copy;
} PyModuleDef_Base;

Expand Down