gh-99325: Remove unused NameError handling#99326
Merged
Merged
Conversation
2 tasks
NameError hanlingNameError handling
21d01b4 to
991fa25
Compare
AlexWaygood
reviewed
Nov 11, 2022
| pass | ||
| # OSError (winerror=1314) will be raised if the caller does not hold the | ||
| # SeCreateSymbolicLinkPrivilege privilege | ||
| symlink_exception = (AttributeError, NotImplementedError, OSError) |
Member
There was a problem hiding this comment.
This alias is now only used once in this file. You could just inline it here:
Line 2278 in 67b4d27
Member
Author
There was a problem hiding this comment.
Someone out there might be using it. So, I went with the safest path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NameErrorhandlers #99325