Skip to content

gh-99127: Allow some features of syslog to the main interpreter only #99128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 23 commits into from
Nov 29, 2022
+122 −2
Merged

gh-99127: Allow some features of syslog to the main interpreter only #99128

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
ced41bc
gh-99127: Port syslog module to use module state.
corona10 Nov 5, 2022
8beb461
Address code review
corona10 Nov 5, 2022
d8acc8b
Remove logic to check the openlog status while calling syslog.syslog
corona10 Nov 5, 2022
11d9228
Do not call openlog while calling syslog
corona10 Nov 5, 2022
e7408a8
Fix test_audit
corona10 Nov 5, 2022
69ac18a
nit
corona10 Nov 6, 2022
3a784f6
Address code review
corona10 Nov 6, 2022
f5cf63a
nit
corona10 Nov 6, 2022
fc85827
Address code review
corona10 Nov 11, 2022
f40d953
Add test
corona10 Nov 11, 2022
35bbac2
nit
corona10 Nov 11, 2022
525a32b
Address code review
corona10 Nov 12, 2022
741baf0
Update NEWS.d
corona10 Nov 12, 2022
779a3d2
nit
corona10 Nov 12, 2022
557578f
Revert some logic
corona10 Nov 12, 2022
01334e8
nit
corona10 Nov 12, 2022
4ad2b8f
Address code review
corona10 Nov 14, 2022
696196d
Update Lib/test/test_syslog.py
corona10 Nov 16, 2022
5eeade5
Address code review
corona10 Nov 16, 2022
fb81c1e
Address code review
corona10 Nov 17, 2022
140366b
Update documentations
corona10 Nov 17, 2022
c961709
Address code review
corona10 Nov 17, 2022
e8dce88
Apply suggestions from code review
corona10 Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
nit
  • Loading branch information
@corona10
corona10 committed Nov 12, 2022
commit 69ac18a8e583c1874b389228c51c857a3ad0c318
10 changes: 8 additions & 2 deletions Modules/syslogmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,12 @@ syslog_closelog_impl(PyObject *module)
_syslog_state *state = get_syslog_state(module);
if (state->S_log_open) {
closelog();
Py_CLEAR(state->S_ident_o);
state->S_log_open = 0;
}

if (state->S_ident_o != NULL) {
Py_CLEAR(state->S_ident_o);
}
Py_RETURN_NONE;
}

Expand Down Expand Up @@ -397,9 +400,12 @@ _syslog_clear(PyObject *module)
_syslog_state *state = get_syslog_state(module);
if (state->S_log_open) {
closelog();
Copy link
Copy Markdown
Member

@vstinner vstinner Nov 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if interpreter A calls closelog() and interpreter B (same process!) still uses the Python syslog module, so after closelog() has been called?

Copy link
Copy Markdown
Member

@ericsnowcurrently ericsnowcurrently Nov 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POSIX syslog will transparently call openlog() with default values.

Py_CLEAR(state->S_ident_o);
state->S_log_open = 0;
}

if (state->S_ident_o != NULL) {
Py_CLEAR(state->S_ident_o);
}
Comment thread
corona10 marked this conversation as resolved.
Outdated
return 0;
}

Expand Down