Skip to content

gh-98644: point people to tomllib from configparser’s docs#98645

Merged
JelleZijlstra merged 2 commits into
python:mainfrom
flying-sheep:configparser-doc-fix
Oct 26, 2022
Merged

gh-98644: point people to tomllib from configparser’s docs#98645
JelleZijlstra merged 2 commits into
python:mainfrom
flying-sheep:configparser-doc-fix

Conversation

@flying-sheep
Copy link
Copy Markdown
Contributor

@flying-sheep flying-sheep commented Oct 25, 2022

Adds tomllib as first seealso entry to configparser’s docs, and discourage using JSON for that purpose.

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 25, 2022
Copy link
Copy Markdown
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Adding tomllib seems like a good idea. It totally needs more exposure, since it is so new.

Copy link
Copy Markdown
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor suggestions

Comment thread Doc/library/configparser.rst Outdated
Comment thread Doc/library/configparser.rst Outdated
@JelleZijlstra JelleZijlstra self-assigned this Oct 25, 2022
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@flying-sheep
Copy link
Copy Markdown
Contributor Author

Both sound good, thanks!

@JelleZijlstra JelleZijlstra merged commit 5e74bad into python:main Oct 26, 2022
@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @flying-sheep for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

GH-98721 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 26, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 26, 2022
…honGH-98645)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 5e74bad)

Co-authored-by: Philipp A <flying-sheep@web.de>
miss-islington added a commit that referenced this pull request Oct 26, 2022
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 5e74bad)

Co-authored-by: Philipp A <flying-sheep@web.de>
@flying-sheep flying-sheep deleted the configparser-doc-fix branch October 28, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants