Skip to content

GH-98539: fix ref cycle in _SSLProtocolTransport after close #98540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 1 commit into from
Oct 22, 2022
Merged

GH-98539: fix ref cycle in _SSLProtocolTransport after close #98540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix ref cycle
  • Loading branch information
@kumaraditya303
kumaraditya303 authored Oct 22, 2022
commit 39a0df291946ec1e83efe2c85cbfb9275547a0bf
7 changes: 5 additions & 2 deletions Lib/asyncio/sslproto.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,11 @@ def close(self):
protocol's connection_lost() method will (eventually) called
with None as its argument.
"""
self._closed = True
self._ssl_protocol._start_shutdown()
if not self._closed:
self._closed = True
self._ssl_protocol._start_shutdown()
Comment thread
kumaraditya303 marked this conversation as resolved.
else:
self._ssl_protocol = None

def __del__(self, _warnings=warnings):
if not self._closed:
Expand Down