Skip to content

gh-98374: Suppress ImportError for invalid query for help() command. #98450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 2 commits into from
Oct 20, 2022
Merged

gh-98374: Suppress ImportError for invalid query for help() command. #98450

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4d5b80
gh-98374: Suppress ImportError for invalid query for help() command.
corona10 Oct 19, 2022
f9619ba
Address code review
corona10 Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-98374: Suppress ImportError for invalid query for help() command.
  • Loading branch information
@corona10
corona10 committed Oct 19, 2022
commit a4d5b80b09319b377838ea85d0aeeabb6a3a88e8
6 changes: 5 additions & 1 deletion Lib/pydoc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1997,7 +1997,11 @@ def __repr__(self):
_GoInteractive = object()
def __call__(self, request=_GoInteractive):
if request is not self._GoInteractive:
self.help(request)
try:
self.help(request)
except ImportError as e:
self.output.write(str(e))
self.output.write("\n")
Comment thread
corona10 marked this conversation as resolved.
Outdated
else:
self.intro()
self.interact()
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2022-10-19-23-48-46.gh-issue-98374.eOBh8M.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Suppress ImportError for invalid query for help() command. Patch by Dong-hee
Na.