Skip to content

General improvements to the itertools docs #98408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhettinger merged 15 commits into from
Oct 18, 2022
Merged

General improvements to the itertools docs #98408

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9a81333
Remove distracting and wordy logostic_map example.
rhettinger Oct 18, 2022
655e624
Make the groupby() code equivalent more readable
rhettinger Oct 18, 2022
b1a632a
Break islice() docs into smaller paragraphs
rhettinger Oct 18, 2022
f874f0c
Minor wording improvements for the combinatoric iterators
rhettinger Oct 18, 2022
2cd06a0
Remove redundant text covered by the example below.
rhettinger Oct 18, 2022
6e655d6
Break string of sentences into two paragraphs
rhettinger Oct 18, 2022
62f4ff6
Remove unnecessary words in tee() docs
rhettinger Oct 18, 2022
81e294a
Improve iter_index() recipe to handle non-sequence iterable inputs
rhettinger Oct 18, 2022
78d49a4
Describe the purpose of the recipes section
rhettinger Oct 18, 2022
3019dfc
Note better alternative for unique_everseen()
rhettinger Oct 18, 2022
256bb59
Missing article
rhettinger Oct 18, 2022
ac0cc45
Markup
rhettinger Oct 18, 2022
78f0586
Add imports for the new doctests
rhettinger Oct 18, 2022
1dff762
Doctest the example
rhettinger Oct 18, 2022
5138ddd
Sphinx requires an actual unicode em dash
rhettinger Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Note better alternative for unique_everseen()
  • Loading branch information
@rhettinger
rhettinger committed Oct 18, 2022
commit 3019dfc7707cceacedd8b2181deb7df4682e3344
9 changes: 6 additions & 3 deletions Doc/library/itertools.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,16 +998,19 @@ which incur interpreter overhead.
# unique_everseen('AAAABBBCCDAABBB') --> A B C D
# unique_everseen('ABBCcAD', str.lower) --> A B C D
seen = set()
seen_add = seen.add
if key is None:
for element in filterfalse(seen.__contains__, iterable):
seen_add(element)
seen.add(element)
yield element
# Note: The steps shown above are intended to demonstrate
# filterfalse(). For order preserving deduplication,
# a better solution is:
# yield from dict.fromkeys(iterable)
else:
for element in iterable:
k = key(element)
if k not in seen:
seen_add(k)
seen.add(k)
yield element

def unique_justseen(iterable, key=None):
Expand Down