Skip to content

[3.10] gh-95971: Turn @writes_bytecode_files to skip when not running (GH-95972) #98280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 1 commit into from
Oct 15, 2022
Merged

[3.10] gh-95971: Turn @writes_bytecode_files to skip when not running (GH-95972) #98280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-95971: Turn @writes_bytecode_files to skip when not running (GH-95972 
)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 07b5c46)

Co-authored-by: Jeong YunWon <69878+youknowone@users.noreply.github.com>
  • Loading branch information
@youknowone @miss-islington
youknowone authored and miss-islington committed Oct 15, 2022
commit c0e86791b1eab9716f60d4a1772451f85ec667fa
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ def writes_bytecode_files(fxn):
"""Decorator to protect sys.dont_write_bytecode from mutation and to skip
tests that require it to be set to False."""
if sys.dont_write_bytecode:
return lambda *args, **kwargs: None
return unittest.skip("relies on writing bytecode")(fxn)
@functools.wraps(fxn)
def wrapper(*args, **kwargs):
original = sys.dont_write_bytecode
Expand Down