Skip to content

gh-98254: Include stdlib module names in error messages for NameErrors #98255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 9 commits into from
Oct 15, 2022
Merged

gh-98254: Include stdlib module names in error messages for NameErrors #98255

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
76d2ada
gh-98254: Include stdlib module names in error messages for NameErrors
pablogsal Oct 13, 2022
21fef72
Add news entry
pablogsal Oct 13, 2022
88555fa
Consider all names
pablogsal Oct 13, 2022
46ce50f
Add more tests
pablogsal Oct 13, 2022
19e8469
Fix refleak
pablogsal Oct 13, 2022
5103f8c
Fix test
pablogsal Oct 13, 2022
a30504e
Fix idle test
pablogsal Oct 14, 2022
ca2c471
Fix whitespace
pablogsal Oct 14, 2022
06cda71
Update Python/suggestions.c
pablogsal Oct 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test
  • Loading branch information
@pablogsal
pablogsal committed Oct 13, 2022
commit 5103f8cfeeed17bc3a2ea2ff1b9699a63a51e668
4 changes: 2 additions & 2 deletions Python/suggestions.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,11 +302,11 @@ offer_suggestions_for_name_error(PyNameErrorObject *exc)
// Add a trailer ". Did you mean: (...)?"
PyObject* result = NULL;
if (!is_stdlib_module) {
result = PyUnicode_FromFormat(". Did you mean %R?", suggestion);
result = PyUnicode_FromFormat(". Did you mean: %R?", suggestion);
} else if (suggestion == NULL) {
result = PyUnicode_FromFormat(". Did you forget to import %R?", name);
} else {
result = PyUnicode_FromFormat(". Did you mean %R? Or did you forget to import %R?", suggestion, name);
result = PyUnicode_FromFormat(". Did you mean: %R? Or did you forget to import %R?", suggestion, name);
}
Py_XDECREF(suggestion);
return result;
Expand Down