Skip to content

gh-91053: Add an optional callback that is invoked whenever a function is modified #98175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 16 commits into from
Nov 22, 2022
Merged

gh-91053: Add an optional callback that is invoked whenever a function is modified #98175

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
89ce99c
Add an optional callback that is invoked whenever a function is modified
mpage Sep 23, 2022
4d4823c
Use imperative mood for all enum values
mpage Nov 8, 2022
acde67e
Update docs
mpage Nov 8, 2022
896d708
Conform to PEP-7
mpage Nov 8, 2022
788ad34
Move tests into test_capi
mpage Nov 8, 2022
c189528
Add a test for allocating too many watchers
mpage Nov 8, 2022
9d3496f
Dispatch events when {kw}defaults are modified via the C-API
mpage Nov 8, 2022
0fdc7d7
Trigger events when {kw}defaults are changed via the C-API
mpage Nov 9, 2022
a79e618
More PEP-7
mpage Nov 9, 2022
e1dd4e4
Merge branch 'main' into func-watchers
mpage Nov 9, 2022
e0601c1
Merge branch 'main' into func-watchers
mpage Nov 10, 2022
9804bba
Merge branch 'main' into func-watchers
mpage Nov 22, 2022
dd41468
Document that the runtime is free to optimize away function creation
mpage Nov 22, 2022
812dd5f
Add a bit vector to optimize watcher dispatch
mpage Nov 22, 2022
f28acc1
Sync with main
erlend-aasland Nov 22, 2022
e7b3325
Revert added newlines to VS project files
erlend-aasland Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Document that the runtime is free to optimize away function creation
  • Loading branch information
@mpage
mpage committed Nov 22, 2022
commit dd41468ea8109dd8f2a643a4c7abb81b04d80250
6 changes: 5 additions & 1 deletion Doc/c-api/function.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,11 @@ There are a few functions specific to Python functions.
If *event* is ``PyFunction_EVENT_CREATE``, then the callback is invoked
after `func` has been fully initialized. Otherwise, the callback is invoked
before the modification to *func* takes place, so the prior state of *func*
can be inspected.
can be inspected. The runtime is permitted to optimize away the creation of
function objects when possible. In such cases no event will be emitted.
Although this creates the possitibility of an observable difference of
runtime behavior depending on optimization decisions, it does not change
the semantics of the Python code being executed.

Comment thread
mpage marked this conversation as resolved.
If the callback returns with an exception set, it must return ``-1``; this
exception will be printed as an unraisable exception using
Expand Down