Skip to content

gh-98003: Inline call frames for CALL_FUNCTION_EX #98004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 20 commits into from
Apr 30, 2023
Merged

gh-98003: Inline call frames for CALL_FUNCTION_EX #98004

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
830084c
Specialize CALL_FUNCTION_EX
Fidget-Spinner Oct 6, 2022
d9fbb11
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 6, 2022
e724666
fix refleak
Fidget-Spinner Oct 6, 2022
01cbef6
Merge branch 'call_function_ex_inline_3' of https://github.com/Fidget…
Fidget-Spinner Oct 6, 2022
92fead8
re-order STACK_SHRINK to fix error case
Fidget-Spinner Oct 6, 2022
84d0f8b
Inline instead of specializing
Fidget-Spinner Oct 7, 2022
1955f19
reduce diff
Fidget-Spinner Oct 7, 2022
eb25c1b
temper expectations
Fidget-Spinner Oct 7, 2022
3f409da
Add newline
Fidget-Spinner Oct 7, 2022
09b2528
remove unused variable
Fidget-Spinner Oct 11, 2022
f0d77dc
remove unused function prototype
Fidget-Spinner Nov 24, 2022
898c75d
Merge remote-tracking branch 'upstream/main' into call_function_ex_in…
Fidget-Spinner Nov 24, 2022
b933f6e
Use new case regenerator
Fidget-Spinner Nov 24, 2022
06ddc00
Apply Mark's and Brandt's suggestion
Fidget-Spinner Nov 30, 2022
bfab4dc
Run --regen
Fidget-Spinner Dec 1, 2022
80194fb
Merge remote-tracking branch 'upstream/main' into call_function_ex_in…
Fidget-Spinner Apr 27, 2023
dfd6b01
Fix merge problems
Fidget-Spinner Apr 27, 2023
1afff6d
Update generated_cases.c.h
Fidget-Spinner Apr 28, 2023
f1a9465
Update Python/bytecodes.c
Fidget-Spinner Apr 29, 2023
94782c3
Update generated_cases.c.h
Fidget-Spinner Apr 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix merge problems 
Co-Authored-By: Brandt Bucher <brandt@python.org>
  • Loading branch information
@Fidget-Spinner @brandtbucher
Fidget-Spinner and brandtbucher committed Apr 27, 2023
commit dfd6b01e99fbb4830d015a8e3e018e5c920ba486
4 changes: 3 additions & 1 deletion Python/bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3114,10 +3114,12 @@ dummy_func(
_PyInterpreterFrame *new_frame = _PyEvalFramePushAndInit_Ex(tstate,
(PyFunctionObject *)func, locals,
nargs, callargs, kwargs);
STACK_SHRINK(2); /* get rid of func and NULL */
// Need to manually shrinkg the stack since we exit with DISPATCH_INLINED.
Comment thread
Fidget-Spinner marked this conversation as resolved.
Outdated
STACK_SHRINK(oparg + 3);
if (new_frame == NULL) {
goto error;
}
frame->return_offset = 0;
DISPATCH_INLINED(new_frame);
}
result = PyObject_Call(func, callargs, kwargs);
Expand Down
1 change: 1 addition & 0 deletions Python/ceval.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1513,6 +1513,7 @@ _PyEvalFramePushAndInit_Ex(PyThreadState *tstate, PyFunctionObject *func,
{
bool has_dict = (kwargs != NULL && PyDict_GET_SIZE(kwargs) > 0);
PyObject *kwnames = NULL;
PyObject *const *newargs;
if (has_dict) {
newargs = _PyStack_UnpackDict(tstate, _PyTuple_ITEMS(callargs), nargs, kwargs, &kwnames);
if (newargs == NULL) {
Expand Down
3 changes: 2 additions & 1 deletion Python/generated_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.