Skip to content

gh-97956: Mention generate_global_objects.py in AC How-To #97957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 4 commits into from
Oct 7, 2022
Merged

gh-97956: Mention generate_global_objects.py in AC How-To #97957

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f130f74
gh-97956: Mention `generate_global_objects.py` in `AC How-To`
sobolevn Oct 6, 2022
f1a23cb
Address review
sobolevn Oct 6, 2022
ad3816b
Merge branch 'main' into patch-11
sobolevn Oct 6, 2022
4439292
Merge branch 'main' into patch-11
sobolevn Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Doc/howto/clinic.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,17 @@ Let's dive in!
};


16. Compile, then run the relevant portions of the regression-test suite.
16. Code generated by Argument Clinic might use ``_Py_ID`` macro inside.
Copy link
Copy Markdown
Contributor

@larryhastings larryhastings Oct 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Argument Clinic may generate new instances of _Py_ID. For example::


Sample::

&_Py_ID(new_unique_py_id)

It means that you would need to run ``Tools/scripts/generate_global_objects.py``
Copy link
Copy Markdown
Contributor

@larryhastings larryhastings Oct 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it does, you'll have to run Tools/scripts/generate_global_objects.py to regenerate the list of precompiled identifiers at this point.

Copy link
Copy Markdown
Member Author

@sobolevn sobolevn Oct 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done!

It is always great to have native-speakers to double check things like this. I think in another language and it does not translate that well into English in some cases :)

script to generate global string objects for the interpreter.


17. Compile, then run the relevant portions of the regression-test suite.
This change should not introduce any new compile-time warnings or errors,
and there should be no externally visible change to Python's behavior.

Expand Down