Skip to content

gh-91051: allow setting a callback hook on PyType_Modified #97875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 21 commits into from
Oct 21, 2022
Merged

gh-91051: allow setting a callback hook on PyType_Modified #97875

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
f2b70a2
gh-91051: allow setting a callback hook on PyType_Modified
carljm Oct 4, 2022
1a28a45
Add NEWS blurb.
carljm Oct 5, 2022
95e49ee
Move new API to Include/cpython so it's not in limited API
carljm Oct 5, 2022
1af2a98
Merge branch 'main' into typewatch
carljm Oct 6, 2022
415ed49
Merge branch 'main' into typewatch
carljm Oct 6, 2022
29e38df
Merge branch 'main' into typewatch
carljm Oct 7, 2022
0de5aff
Merge branch 'main' into typewatch
carljm Oct 7, 2022
27a4980
Merge branch 'main' into typewatch
carljm Oct 7, 2022
d67d6fd
Merge branch 'main' into typewatch
carljm Oct 8, 2022
cb71ae9
Multiple watchers and per-type watching
carljm Oct 8, 2022
ab1606c
Update NEWS blurb
carljm Oct 8, 2022
26ddee2
Fix doc build issues
carljm Oct 8, 2022
4783e07
Fix typeobject size test
carljm Oct 8, 2022
71d48c1
Merge branch 'main' into typewatch
carljm Oct 9, 2022
21f42ee
Fix issue number in whatsnew (and add for dict watchers too)
carljm Oct 9, 2022
6e53514
Merge branch 'main' into typewatch
carljm Oct 14, 2022
2b42bfe
Type watcher review comments
carljm Oct 14, 2022
cdbe93b
Merge branch 'main' into typewatch
carljm Oct 17, 2022
4329743
Review comments
carljm Oct 17, 2022
8bba5da
Merge branch 'main' into typewatch
carljm Oct 20, 2022
22d190b
Short circuit watched bits check if no more bits are set
carljm Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Short circuit watched bits check if no more bits are set
  • Loading branch information
@carljm
carljm committed Oct 20, 2022
commit 22d190b0adced2a90130624e6e172224eb1a7741
6 changes: 4 additions & 2 deletions Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,14 +488,16 @@ PyType_Modified(PyTypeObject *type)

if (type->tp_watched) {
PyInterpreterState *interp = _PyInterpreterState_GET();
char bits = type->tp_watched;
for (int i = 0; i < TYPE_MAX_WATCHERS; i++) {
int bits = type->tp_watched;
int i = 0;
while(bits && i < TYPE_MAX_WATCHERS) {
Comment thread
erlend-aasland marked this conversation as resolved.
if (bits & 1) {
PyType_WatchCallback cb = interp->type_watchers[i];
if (cb && (cb(type) < 0)) {
PyErr_WriteUnraisable((PyObject *)type);
}
}
i += 1;
bits >>= 1;
}
}
Expand Down