Skip to content

gh-97740: Fix bang in Sphinx C domain ref target syntax #97741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ezio-melotti merged 2 commits into from
Oct 3, 2022
Merged

gh-97740: Fix bang in Sphinx C domain ref target syntax #97741

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edda9dd
gh-97740: Fix bang in Sphinx C domain ref target syntax
CAM-Gerlach Oct 2, 2022
1397a42
Add NEWS entry for C domain bang fix
CAM-Gerlach Oct 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-97740: Fix bang in Sphinx C domain ref target syntax 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
  • Loading branch information
@CAM-Gerlach @AA-Turner
CAM-Gerlach and AA-Turner committed Oct 2, 2022
commit edda9ddc20f7e145de31271f4621bede82b96f2b
15 changes: 15 additions & 0 deletions Doc/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,3 +249,18 @@
# bpo-40204: Disable warnings on Sphinx 2 syntax of the C domain since the
# documentation is built with -W (warnings treated as errors).
c_warn_on_allowed_pre_v3 = False

# Fix '!' not working with C domain when pre_v3 is enabled
import sphinx

if sphinx.version_info[:2] < (5, 3):
from sphinx.domains.c import CXRefRole

original_run = CXRefRole.run

def new_run(self):
if self.disabled:
return super(CXRefRole, self).run()
return original_run(self)

CXRefRole.run = new_run