Skip to content

gh-82836: fix private network check #97733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 7 commits into from
Nov 29, 2022
Merged

gh-82836: fix private network check #97733

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
652b43f
gh-82836: fix private network check
JamoBox Oct 2, 2022
b8164c4
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 2, 2022
3042e65
Fix NEWS
JamoBox Oct 2, 2022
e218eef
Fix typo in test
JamoBox Oct 2, 2022
c814b41
Improve docstring for is_private
JamoBox Oct 2, 2022
406a7bc
Update Misc/NEWS.d/next/Library/2022-10-02-12-38-22.gh-issue-82836.Ov…
JamoBox Oct 4, 2022
26be8a0
Merge branch 'fix-issue-82836' of https://github.com/JamoBox/cpython …
JamoBox Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo in test
  • Loading branch information
@JamoBox
JamoBox committed Oct 2, 2022
commit e218eef4dceadf7363ec5c91b54e18ea999ff8ea
2 changes: 1 addition & 1 deletion Lib/test/test_ipaddress.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2279,7 +2279,7 @@ def testReservedIpv4(self):

def testPrivateNetworks(self):
self.assertEqual(False, ipaddress.ip_network("0.0.0.0/0").is_private)
Comment thread
gpshead marked this conversation as resolved.
Comment thread
gpshead marked this conversation as resolved.
self.assertEqual(False, ipaddress.ip_network("1.0.0.0/0").is_private)
self.assertEqual(False, ipaddress.ip_network("1.0.0.0/8").is_private)

self.assertEqual(True, ipaddress.ip_network("0.0.0.0/8").is_private)
self.assertEqual(True, ipaddress.ip_network("10.0.0.0/8").is_private)
Expand Down