Skip to content

gh-97591: In Exception.__setstate__(), acquire strong reference before calling tp_hash slot. #97700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 4 commits into from
Oct 2, 2022
Merged

gh-97591: In Exception.__setstate__(), acquire strong reference before calling tp_hash slot. #97700

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
859e993
patch BaseException_setstate and its test.
ofey404 Oct 1, 2022
d86ff33
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 1, 2022
0028446
Patchcheck.
ofey404 Oct 1, 2022
b5dfd41
Update Misc/NEWS.d/next/Core and Builtins/2022-10-01-08-55-09.gh-issu…
ofey404 Oct 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Patchcheck.
  • Loading branch information
@ofey404
ofey404 committed Oct 1, 2022
commit 002844648d3fdff0bd04f776a02f357a71c0e326
2 changes: 1 addition & 1 deletion Lib/test/test_baseexception.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ class Value(str):
d[HashThisKeyWillClearTheDict()] = Value() # refcount of Value() is 1 now

# Exception.__setstate__ should aquire a strong reference of key and
# value in the dict. Otherwise, Value()'s refcount would go below
# value in the dict. Otherwise, Value()'s refcount would go below
# zero in the tp_hash call in PyObject_SetAttr(), and it would cause
# crash in GC.
exc.__setstate__(d) # __hash__() is called again here, clearing the dict.
Expand Down