Skip to content

gh-97607: Fix content parsing in the impl-detail reST directive #97652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ezio-melotti merged 3 commits into from
Oct 2, 2022
Merged

gh-97607: Fix content parsing in the impl-detail reST directive #97652

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00e5bcc
Don't parse content as arg in the impl-detail directive
CAM-Gerlach Sep 29, 2022
9dcab9c
Remove unused branch from impl-detail directive handling no-content case
CAM-Gerlach Sep 29, 2022
b8789b8
Further simplify impl-detail reST directive code
CAM-Gerlach Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Don't parse content as arg in the impl-detail directive 
This does not change the (untranslated) output,
but ensures that the doctree node metadata is correct.
which fixes gh-97607 with the text not being translated.
It also simplifies the code and logic
and makes it consistant with the docutils built-in directives.
  • Loading branch information
@CAM-Gerlach
CAM-Gerlach committed Sep 29, 2022
commit 00e5bccceff33538c852c69c0e7af9eec4e5f705
5 changes: 0 additions & 5 deletions Doc/tools/extensions/pyspecific.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,6 @@ def source_role(typ, rawtext, text, lineno, inliner, options={}, content=[]):
class ImplementationDetail(Directive):

has_content = True
required_arguments = 0
optional_arguments = 1
final_argument_whitespace = True

# This text is copied to templates/dummy.html
Expand All @@ -112,9 +110,6 @@ def run(self):
label = translators['sphinx'].gettext(self.label_text)
content = self.content
add_text = nodes.strong(label, label)
if self.arguments:
n, m = self.state.inline_text(self.arguments[0], self.lineno)
pnode.append(nodes.paragraph('', '', *(n + m)))
self.state.nested_parse(content, self.content_offset, pnode)
if pnode.children and isinstance(pnode[0], nodes.paragraph):
content = nodes.inline(pnode[0].rawsource, translatable=True)
Expand Down