Skip to content

[3.9] gh-97616: list_resize() checks for integer overflow (GH-97617) - #97627

Merged
ambv merged 1 commit into
python:3.9from
miss-islington:backport-a5f092f-3.9
Oct 4, 2022
Merged

[3.9] gh-97616: list_resize() checks for integer overflow (GH-97617)#97627
ambv merged 1 commit into
python:3.9from
miss-islington:backport-a5f092f-3.9

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 28, 2022

Copy link
Copy Markdown
Contributor

Fix multiplying a list by an integer (list *= int): detect the
integer overflow when the new allocated length is close to the
maximum size. Issue reported by Jordan Limor.

list_resize() now checks for integer overflow before multiplying the
new allocated length by the list item size (sizeof(PyObject*)).
(cherry picked from commit a5f092f)

Co-authored-by: Victor Stinner vstinner@python.org

…7617)

Fix multiplying a list by an integer (list *= int): detect the
integer overflow when the new allocated length is close to the
maximum size.  Issue reported by Jordan Limor.

list_resize() now checks for integer overflow before multiplying the
new allocated length by the list item size (sizeof(PyObject*)).
(cherry picked from commit a5f092f)

Co-authored-by: Victor Stinner <vstinner@python.org>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅.

@miss-islington

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@ambv
ambv merged commit f65f3a9 into python:3.9 Oct 4, 2022
@miss-islington
miss-islington deleted the backport-a5f092f-3.9 branch October 4, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-security A security issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants