Skip to content

bpo-2506: Experiment with adding a "-X noopt" flag #9693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1st1 wants to merge 2 commits into from
Closed

bpo-2506: Experiment with adding a "-X noopt" flag #9693

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5612974
bpo-2506: Experiment with adding a "-X noopt" flag
1st1 Oct 4, 2018
10d3814
Disable both "if <const>" and "while <const>" optimizations
1st1 Oct 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Disable both "if <const>" and "while <const>" optimizations
  • Loading branch information
@1st1
1st1 committed Oct 4, 2018
commit 10d3814187affa000f3cc82740acd0da0bf5afc6
14 changes: 7 additions & 7 deletions Python/compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ static int compiler_visit_slice(struct compiler *, slice_ty,
expr_context_ty);

static int inplace_binop(struct compiler *, operator_ty);
static int expr_constant(expr_ty);
static int expr_constant(struct compiler *, expr_ty);

static int compiler_with(struct compiler *, stmt_ty, int);
static int compiler_async_with(struct compiler *, stmt_ty, int);
Expand Down Expand Up @@ -2374,7 +2374,7 @@ compiler_if(struct compiler *c, stmt_ty s)
if (end == NULL)
return 0;

constant = expr_constant(s->v.If.test);
constant = expr_constant(c, s->v.If.test);
/* constant = 0: "if 0"
* constant = 1: "if 1", "if 2", ...
* constant = -1: rest */
Expand Down Expand Up @@ -2488,10 +2488,7 @@ compiler_while(struct compiler *c, stmt_ty s)
{
basicblock *loop, *orelse, *end, *anchor = NULL;

int constant = -1;
if (!c->c_noopt) {
constant = expr_constant(s->v.While.test);
}
int constant = expr_constant(c, s->v.While.test);

if (constant == 0) {
if (s->v.While.orelse)
Expand Down Expand Up @@ -4218,8 +4215,11 @@ compiler_visit_keyword(struct compiler *c, keyword_ty k)
*/

static int
expr_constant(expr_ty e)
expr_constant(struct compiler *c, expr_ty e)
{
if (c->c_noopt) {
return -1;
}
if (e->kind == Constant_kind) {
return PyObject_IsTrue(e->v.Constant.value);
}
Expand Down