Skip to content

GH-96704: Add task.get_context(), use it in call_exception_handler() #96756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 7 commits into from
Oct 5, 2022
Merged

GH-96704: Add task.get_context(), use it in call_exception_handler() #96756

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1d2d081
GH-96704: Add task.get_context(), use it in call_exception_handler()
gvanrossum Sep 11, 2022
9fbc1d8
add two tests
kumaraditya303 Sep 17, 2022
bc3000b
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 18, 2022
bcd1a4a
Also look in handle for contextvars
gvanrossum Oct 4, 2022
d9ccfe3
Update NEWS
gvanrossum Oct 4, 2022
a362fc0
Document the {Task,Handle}.get_context() methods
gvanrossum Oct 4, 2022
0ca5023
Document change for exception handler
gvanrossum Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add two tests
  • Loading branch information
@kumaraditya303 @gvanrossum
kumaraditya303 authored and gvanrossum committed Oct 4, 2022
commit 9fbc1d8f4bc16c0da6b92e831a8b454bc5d34230
20 changes: 20 additions & 0 deletions Lib/test/test_asyncio/test_futures2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# IsolatedAsyncioTestCase based tests
import asyncio
import contextvars
import traceback
import unittest
from asyncio import tasks
Expand Down Expand Up @@ -27,6 +28,25 @@ async def raise_exc():
else:
self.fail('TypeError was not raised')

async def test_task_exc_handler_correct_context(self):
# see https://github.com/python/cpython/issues/96704
name = contextvars.ContextVar('name', default='foo')
exc_handler_called = False
def exc_handler(*args):
self.assertEqual(name.get(), 'bar')
nonlocal exc_handler_called
exc_handler_called = True

async def task():
name.set('bar')
1/0

loop = asyncio.get_running_loop()
loop.set_exception_handler(exc_handler)
self.cls(task())
await asyncio.sleep(0)
self.assertTrue(exc_handler_called)

@unittest.skipUnless(hasattr(tasks, '_CTask'),
'requires the C _asyncio module')
class CFutureTests(FutureTests, unittest.IsolatedAsyncioTestCase):
Expand Down
11 changes: 11 additions & 0 deletions Lib/test/test_asyncio/test_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2482,6 +2482,17 @@ def test_get_coro(self):
finally:
loop.close()

def test_get_context(self):
loop = asyncio.new_event_loop()
coro = coroutine_function()
context = contextvars.copy_context()
try:
task = self.new_task(loop, coro, context=context)
loop.run_until_complete(task)
self.assertIs(task.get_context(), context)
finally:
loop.close()


def add_subclass_tests(cls):
BaseTask = cls.Task
Expand Down