Improvements to typing documentation#967
Merged
Merged
Conversation
Documents a few omitted classes and adds NamedTuple methods.
|
@JelleZijlstra, thanks for your PR! By analyzing the history of the files in this pull request, we identified @berkerpeksag, @zware and @brettcannon to be potential reviewers. |
Member
Author
|
The Travis failure appears to be a Sphinx bug. Reported as sphinx-doc/sphinx#3600. |
Contributor
|
Indeed, it was already reported at sphinx-doc/sphinx#3597, waiting for sphinx-doc/sphinx#3598 to be resolved. |
ilevkivskyi
approved these changes
Apr 3, 2017
Member
ilevkivskyi
left a comment
There was a problem hiding this comment.
Thank you for PR! This looks good to me.
(I have noticed inconsistent formatting (number of leading spaces), but I think there should be a separate PR fixing it in the whole file.)
Contributor
|
LGTM |
berkerpeksag
approved these changes
Apr 8, 2017
Mariatta
pushed a commit
to Mariatta/cpython
that referenced
this pull request
Apr 9, 2017
Documents a few omitted classes and adds NamedTuple methods. (cherry picked from commit 45d22c2)
Mariatta
added a commit
that referenced
this pull request
Apr 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents a few omitted classes and adds NamedTuple methods.
@ilevkivskyi would you mind reviewing this?