Skip to content

gh-96641: Do not expose KeyWrapper in _functoolsmodule.c#96642

Merged
corona10 merged 1 commit into
python:mainfrom
sobolevn:issue-96641
Sep 7, 2022
Merged

gh-96641: Do not expose KeyWrapper in _functoolsmodule.c#96642
corona10 merged 1 commit into
python:mainfrom
sobolevn:issue-96641

Conversation

@sobolevn

@sobolevn sobolevn commented Sep 7, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

After:

Python 3.12.0a0 (heads/main-dirty:0d04b8d9e1, Sep  7 2022, 13:35:21) [Clang 11.0.0 (clang-1100.0.33.16)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from _functools import KeyWrapper
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name 'KeyWrapper' from '_functools' (unknown location)
>>>

@sobolevn
sobolevn requested a review from rhettinger as a code owner September 7, 2022 10:37
corona10
corona10 approved these changes Sep 7, 2022
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
This should not be exposed.

@corona10 corona10 added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes and removed awaiting merge labels Sep 7, 2022
@corona10
corona10 merged commit 2fd7246 into python:main Sep 7, 2022
@miss-islington

miss-islington commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 7, 2022
@bedevere-bot

bedevere-bot commented Sep 7, 2022

Copy link
Copy Markdown

GH-96644 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 7, 2022
@sobolevn @miss-islington
pythongh-96641: Do not expose KeyWrapper in _functoolsmodule.c (p…
77834cb 
…ythongh-96642)

(cherry picked from commit 2fd7246)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 7, 2022
@bedevere-bot

bedevere-bot commented Sep 7, 2022

Copy link
Copy Markdown

GH-96645 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 7, 2022
@sobolevn @miss-islington
pythongh-96641: Do not expose KeyWrapper in _functoolsmodule.c (p…
945b8f7 
…ythongh-96642)

(cherry picked from commit 2fd7246)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@sobolevn

sobolevn commented Sep 7, 2022

Copy link
Copy Markdown
Member Author

Thank you!

miss-islington added a commit that referenced this pull request Sep 7, 2022
@miss-islington @sobolevn
gh-96641: Do not expose KeyWrapper in _functoolsmodule.c (gh-96642)
eecbb54 
(cherry picked from commit 2fd7246)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Sep 7, 2022
@miss-islington @sobolevn
gh-96641: Do not expose KeyWrapper in _functoolsmodule.c (gh-96642)
8228433 
(cherry picked from commit 2fd7246)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn @miss-islington @bedevere-bot @corona10