Skip to content

gh-96512: Modernize int_max_str_digits protection in 3.12 #96568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gpshead wants to merge 7 commits into from
Closed

gh-96512: Modernize int_max_str_digits protection in 3.12 #96568

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
25aa726
Revert "Undo addition to PyConfig to ease backporting."
gpshead Sep 4, 2022
67c9af4
Pedantically use int32_t instead of int for max.
gpshead Sep 4, 2022
c6e7f33
Generate audit events on >threshold conversions.
gpshead Sep 5, 2022
e51cb02
versionadded/changed to 3.11; update What's New.
gpshead Sep 5, 2022
65fa579
Merge remote-tracking branch 'upstream/main' into cleanup/int-dos
gpshead Sep 15, 2022
fe9f4d0
Fix missing : in new docs typo.
gpshead Sep 15, 2022
38077ca
NEWS entry about the audit hooks added.
gpshead Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/main' into cleanup/int-dos
  • Loading branch information
@gpshead
gpshead committed Sep 15, 2022
commit 65fa5793e0ac1071ab02338e35c604e6fd2cdacb
11 changes: 11 additions & 0 deletions Lib/test/audit-tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,17 @@ def hook(event, args):
sys._getframe()


def test_wmi_exec_query():
import _wmi

def hook(event, args):
if event.startswith("_wmi."):
print(event, args[0])

sys.addaudithook(hook)
_wmi.exec_query("SELECT * FROM Win32_OperatingSystem")


def test_int_digits():
def hook(event, args):
if event.startswith("int/digits/"):
Expand Down
15 changes: 15 additions & 0 deletions Lib/test/test_audit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,21 @@ def test_sys_getframe(self):

self.assertEqual(actual, expected)


def test_wmi_exec_query(self):
import_helper.import_module("_wmi")
returncode, events, stderr = self.run_python("test_wmi_exec_query")
if returncode:
self.fail(stderr)

if support.verbose:
print(*events, sep='\n')
actual = [(ev[0], ev[2]) for ev in events]
expected = [("_wmi.exec_query", "SELECT * FROM Win32_OperatingSystem")]

self.assertEqual(actual, expected)


def test_int_digits(self):
returncode, events, stderr = self.run_python("test_int_digits")
if returncode:
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.