Skip to content

gh-95778: Add pre-check for int-to-str conversion #96537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 14 commits into from
Sep 4, 2022
+107 −7
Merged

gh-95778: Add pre-check for int-to-str conversion #96537

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2fbc9ce
Add pre-check for int-to-str conversion
mdickinson Sep 3, 2022
d16db91
Avoid potential undefined behaviour from overflow
mdickinson Sep 3, 2022
66a07ac
Reworked, even cruder bound, that avoids potential issues with intege…
mdickinson Sep 3, 2022
6eadbda
Rename the error message constants.
gpshead Sep 4, 2022
195686c
Add a DoS prevention success timed regression test.
gpshead Sep 4, 2022
87bd23d
Improve the test to check close to the limit.
gpshead Sep 4, 2022
de9ed4d
Use fewer digits in the test to speed it up on slow hosts.
gpshead Sep 4, 2022
dbd8da9
Misc: Fix a typo in the header comment.
gpshead Sep 4, 2022
c49a737
Change timers if process_time() returns 0. #wasm
gpshead Sep 4, 2022
35c5ea7
Merge branch 'main' into fix/int-to-str-dos
gpshead Sep 4, 2022
730915d
Update comment to suggest reading the PR for detail
gpshead Sep 4, 2022
56f08c2
Minor comment typo fix (restart CI).
gpshead Sep 4, 2022
4dae3e0
cleanup the test.
gpshead Sep 4, 2022
adb1784
Add Mark's name to the NEWS entry.
gpshead Sep 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve the test to check close to the limit.
  • Loading branch information
@gpshead
gpshead committed Sep 4, 2022
commit 87bd23d3df3aca81b88a5f245e70fded7055ab92
20 changes: 12 additions & 8 deletions Lib/test/test_int.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,10 +651,13 @@ def test_denial_of_service_prevented_int_to_str(self):
self.assertGreater(seconds_to_convert, 0.02,
msg="'We're gonna need a bigger boat (int).'")

with self.assertRaises(ValueError) as err:
start = process_time()
str(huge_int)
seconds_to_fail_huge = process_time() - start
# We test with the limit almost at the size needed to check performance.
# The performant limit check is slightly fuzzy, give it a some room.
with support.adjust_int_max_str_digits(int(.995 * 120_412)):
with self.assertRaises(ValueError) as err:
start = process_time()
str(huge_int)
seconds_to_fail_huge = process_time() - start
self.assertIn('conversion', str(err.exception))
self.assertLess(seconds_to_fail_huge, seconds_to_convert/8)

Expand Down Expand Up @@ -686,10 +689,11 @@ def test_denial_of_service_prevented_str_to_int(self):
self.assertGreater(seconds_to_convert, 0.02,
msg="'We're gonna need a bigger boat (str).'")

with self.assertRaises(ValueError) as err:
start = process_time()
int(huge)
seconds_to_fail_huge = process_time() - start
with support.adjust_int_max_str_digits(200_000 - 1):
with self.assertRaises(ValueError) as err:
start = process_time()
int(huge)
seconds_to_fail_huge = process_time() - start
self.assertIn('conversion', str(err.exception))
self.assertLess(seconds_to_fail_huge, seconds_to_convert/8)

Expand Down