Skip to content

Fix documentation typo for pathlib.Path.walk#96301

Merged
brettcannon merged 1 commit intopython:mainfrom
ansabgillani:gh-96279/fix-documentation-typo-pathlib.Path.walk
Aug 26, 2022
Merged

Fix documentation typo for pathlib.Path.walk#96301
brettcannon merged 1 commit intopython:mainfrom
ansabgillani:gh-96279/fix-documentation-typo-pathlib.Path.walk

Conversation

@ansabgillani
Copy link
Copy Markdown
Contributor

@ansabgillani ansabgillani commented Aug 26, 2022

No description provided.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting review labels Aug 26, 2022
Copy link
Copy Markdown
Contributor

@marco-buttu marco-buttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment for @brettcannon . This example is not the right one to advocate doctests "as much as possible", but also here it was maybe possible to create a TemporaryDirectory in the testsetup directive, and use it for the example

@brettcannon
Copy link
Copy Markdown
Member

@marco-buttu possibly, but I haven't dug into our doc examples to see if we are doing that much I/O-related stuff to keep doc builds fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants