gh-96280: suppress deprecation warning in test_importlib#96281
Merged
iritkatriel merged 1 commit intopython:mainfrom Aug 26, 2022
Merged
gh-96280: suppress deprecation warning in test_importlib#96281iritkatriel merged 1 commit intopython:mainfrom
iritkatriel merged 1 commit intopython:mainfrom
Conversation
mdboom
approved these changes
Aug 25, 2022
warsaw
approved these changes
Aug 25, 2022
Member
warsaw
left a comment
There was a problem hiding this comment.
Approved, but see the comment in the ticket.
Member
Author
|
Let’s hold off merging and see if @brettcannon has a view. |
Member
|
I'm fine with it as a quick fix, but it's effectively just postponing having to deal with it for 3.14 when the class disappears. |
brettcannon
approved these changes
Aug 26, 2022
Member
Author
|
I’ll merge this and leave the issue open. I wanted to mark it as a 3.14 release blocker but we don’t have a 3.14 label yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96280.