Skip to content

gh-91210: Improve error message when non-default param follows default#95933

Merged
miss-islington merged 5 commits into
python:mainfrom
lysnikolaou:gh91210-default-arguments-error-message
Sep 17, 2022
Merged

gh-91210: Improve error message when non-default param follows default#95933
miss-islington merged 5 commits into
python:mainfrom
lysnikolaou:gh91210-default-arguments-error-message

Conversation

@lysnikolaou
Copy link
Copy Markdown
Member

@lysnikolaou lysnikolaou commented Aug 12, 2022 •
edited by miss-islington
Loading

  • Improve error message when parameter without a default follows one with a default
  • Show same error message when positional-only params precede the default/non-default sequence

Automerge-Triggered-By: GH:lysnikolaou

@lysnikolaou
pythongh-91210: Improve error message when non-default param follows …
ce567f3 
…default

- Improve error message when parameter without a default follows one
  with a default
- Show same error message when positional-only params precede the
  default/non-default sequence
@lysnikolaou lysnikolaou requested a review from pablogsal as a code owner August 12, 2022 18:10
@lysnikolaou
Copy link
Copy Markdown
Member Author

lysnikolaou commented Sep 17, 2022

@pablogsal Very slight nudge on this.

pablogsal
pablogsal reviewed Sep 17, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2022-08-12-18-13-49.gh-issue-91210.AWMSLj.rst Outdated
pablogsal
pablogsal approved these changes Sep 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small nit on the commit message.

Thanks for working on this 🚀

@lysnikolaou
Copy link
Copy Markdown
Member Author

lysnikolaou commented Sep 17, 2022

@pablogsal I guess we're not backporting this, correct?

@miss-islington miss-islington merged commit 7e36abb into python:main Sep 17, 2022
@lysnikolaou lysnikolaou deleted the gh91210-default-arguments-error-message branch September 17, 2022 17:09
@pablogsal
Copy link
Copy Markdown
Member

pablogsal commented Sep 17, 2022 •
edited
Loading

@pablogsal I guess we're not backporting this, correct?

Unfortunately, we cannot backport it, since it's technically an improvement

@smheidrich smheidrich mentioned this pull request Feb 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lysnikolaou @pablogsal @bedevere-bot @miss-islington