Skip to content

Trivial change: Misleading zip64 limit error message #95892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 2 commits into from
Nov 30, 2022
+2 −2
Merged

Trivial change: Misleading zip64 limit error message #95892

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7869d7e
Change confusing error message
dmjohnsson23 Nov 28, 2022
e0265fb
Merge branch 'main' into patch-1
kumaraditya303 Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Change confusing error message 
This error message can mistakenly confuse people into thinking that the zip file is already using zip64, when in fact the problem is that they are not using zip64.
  • Loading branch information
@dmjohnsson23
dmjohnsson23 authored Nov 28, 2022
commit 7869d7ef661cab771f52f522421c38b2bb3372bb
4 changes: 2 additions & 2 deletions Lib/zipfile/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1202,10 +1202,10 @@ def close(self):
if not self._zip64:
if self._file_size > ZIP64_LIMIT:
raise RuntimeError(
'File size unexpectedly exceeded ZIP64 limit')
'File size too large, try using force_zip64')
if self._compress_size > ZIP64_LIMIT:
raise RuntimeError(
'Compressed size unexpectedly exceeded ZIP64 limit')
'Compressed size too large, try using force_zip64')
# Seek backwards and write file header (which will now include
# correct CRC and file sizes)

Expand Down