Skip to content

gh-128234: support emscripten and wasi in async contextlib tests, by removing asyncio from contextlib async tests#95888

Merged
kumaraditya303 merged 6 commits into
python:mainfrom
graingert:remove-asyncio-from-contextlib-async-tests
Dec 25, 2024
Merged

gh-128234: support emscripten and wasi in async contextlib tests, by removing asyncio from contextlib async tests#95888
kumaraditya303 merged 6 commits into
python:mainfrom
graingert:remove-asyncio-from-contextlib-async-tests

Conversation

@graingert
Copy link
Copy Markdown
Contributor

@graingert graingert commented Aug 11, 2022 •
edited by bedevere-app Bot
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 11, 2022
@graingert graingert requested a review from iritkatriel August 11, 2022 14:25
@graingert graingert mentioned this pull request Aug 11, 2022
Open
@graingert graingert changed the title remove asyncio from contextlib async tests support emscrpten and wasi in async contextlib tests, by removing asyncio from contextlib async tests Dec 25, 2024
@graingert graingert force-pushed the remove-asyncio-from-contextlib-async-tests branch from 61f0545 to 0461429 Compare December 25, 2024 08:22
@graingert graingert marked this pull request as ready for review December 25, 2024 08:23
@graingert graingert requested a review from 1st1 as a code owner December 25, 2024 08:23
@graingert graingert changed the title support emscrpten and wasi in async contextlib tests, by removing asyncio from contextlib async tests gh-128234: support emscrpten and wasi in async contextlib tests, by removing asyncio from contextlib async tests Dec 25, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Dec 25, 2024
Closed
@graingert graingert changed the title gh-128234: support emscrpten and wasi in async contextlib tests, by removing asyncio from contextlib async tests gh-128234: support emscripten and wasi in async contextlib tests, by removing asyncio from contextlib async tests Dec 25, 2024
kumaraditya303
kumaraditya303 reviewed Dec 25, 2024
View reviewed changes
Comment thread Lib/test/test_contextlib_async.py Outdated
kumaraditya303
kumaraditya303 reviewed Dec 25, 2024
View reviewed changes
Comment thread Lib/test/test_contextlib_async.py Outdated
@graingert @kumaraditya303
Update Lib/test/test_contextlib_async.py
05a1bbf 
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
asvetlov
asvetlov approved these changes Dec 25, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

kumaraditya303
kumaraditya303 reviewed Dec 25, 2024
View reviewed changes
Comment thread Lib/test/test_contextlib_async.py Outdated
graingert and others added 2 commits December 25, 2024 11:42
@kumaraditya303 kumaraditya303 enabled auto-merge (squash) December 25, 2024 11:53
kumaraditya303
kumaraditya303 reviewed Dec 25, 2024
View reviewed changes
Comment thread Lib/test/test_contextlib_async.py Outdated
@kumaraditya303 kumaraditya303 merged commit 81636d3 into python:main Dec 25, 2024
@graingert graingert deleted the remove-asyncio-from-contextlib-async-tests branch December 25, 2024 13:24
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@graingert @kumaraditya303 @srinivasreddy
pythongh-128234: support emscripten and wasi in async contextlib test…
6ee8471 
…s by removing asyncio from contextlib async tests (python#95888)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@asvetlov asvetlov asvetlov approved these changes

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

@1st1 1st1 Awaiting requested review from 1st1

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@graingert @asvetlov @kumaraditya303 @bedevere-bot