Skip to content

[3.10] gh-95349: Hide a Distutils Warning Filter for test_check_c_globals (GH-95837) #95864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 1 commit into from
Aug 11, 2022
Merged

[3.10] gh-95349: Hide a Distutils Warning Filter for test_check_c_globals (GH-95837) #95864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-95349: Hide a Distutils Warning Filter for test_check_c_globals (G… 
…H-95837)

Under certain build conditions, test_check_c_globals fails.  This fix takes the same approach as we took for gh-84236 (via gh-20095).  We'll be removing use of distutils in the c-analyzer at some point.  Until then we'll hide the warning filter.
(cherry picked from commit 3ff6d9a)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
  • Loading branch information
@ericsnowcurrently @miss-islington
ericsnowcurrently authored and miss-islington committed Aug 10, 2022
commit 0d7ed30e06a2e1eb03ddbca517f627e6b6f8827c
7 changes: 6 additions & 1 deletion Lib/test/test_check_c_globals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
import unittest
import test.test_tools
from test.support.warnings_helper import save_restore_warnings_filters

test.test_tools.skip_if_missing('c-analyzer')
with test.test_tools.imports_under_tool('c-analyzer'):
from cpython.__main__ import main
# gh-95349: Save/restore warnings filters to leave them unchanged.
# Importing the c-analyzer imports docutils which imports pkg_resources
# which adds a warnings filter.
with save_restore_warnings_filters():
from cpython.__main__ import main


class ActualChecks(unittest.TestCase):
Expand Down