Skip to content

gh-80480: Emit DeprecationWarning for array's 'u' type code #95760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 14 commits into from
Jun 11, 2023
Merged

gh-80480: Emit DeprecationWarning for array's 'u' type code #95760

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7b020ce
gh-80480 Emit DeprecationWarning for array's 'u' type code
hugovk Aug 7, 2022
19ed73c
gh-80480: Simplify test
hugovk Aug 14, 2022
409468c
Merge branch 'main' into 80480-deprecate-array-u
hugovk May 23, 2023
2fb57bc
Bump removal for Python 3.15
hugovk May 23, 2023
91e75ec
Merge remote-tracking branch 'upstream/main' into 80480-deprecate-arr…
hugovk Jun 4, 2023
115afcc
Merge remote-tracking branch 'upstream/main' into 80480-deprecate-arr…
hugovk Jun 4, 2023
c9637c9
Bump removal for Python 3.16
hugovk Jun 4, 2023
a0f256c
Remove duplicate entry
hugovk Jun 4, 2023
dc167af
Add 'w' typecode to test
hugovk Jun 5, 2023
5956887
Suggest 'w' as a replacement
hugovk Jun 6, 2023
e3b96bb
Move warning after audit
hugovk Jun 6, 2023
8a0c728
Remove unrelated
hugovk Jun 6, 2023
6e7bff6
Move 'u' test to own method
hugovk Jun 6, 2023
f480c58
Remove subsection titles, they're for deprecations from earlier releases
hugovk Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move warning after audit
  • Loading branch information
@hugovk
hugovk committed Jun 6, 2023
commit e3b96bb6eec9bbc6f4c8cfda012decdcd0380795
10 changes: 5 additions & 5 deletions Modules/arraymodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2674,6 +2674,11 @@ array_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
if (!PyArg_ParseTuple(args, "C|O:array", &c, &initial))
return NULL;

if (PySys_Audit("array.__new__", "CO",
c, initial ? initial : Py_None) < 0) {
return NULL;
}

if (c == 'u') {
if (PyErr_WarnEx(PyExc_DeprecationWarning,
"The 'u' type code is deprecated and "
Expand All @@ -2683,11 +2688,6 @@ array_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
}
}

if (PySys_Audit("array.__new__", "CO",
c, initial ? initial : Py_None) < 0) {
return NULL;
}

bool is_unicode = c == 'u' || c == 'w';

if (initial && !is_unicode) {
Expand Down