Skip to content

gh-95504: Fix sign placement in PyUnicode_FromFormat #95505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philg314 wants to merge 8 commits into from
Closed

gh-95504: Fix sign placement in PyUnicode_FromFormat #95505

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2d6f3e1
Add tests for PyUnicode_FromFormat
philg314 Jul 29, 2022
bd72e2a
Fix negative numbers in PyUnicode_FromFormat
philg314 Jul 29, 2022
95b4f83
Merge remote-tracking branch 'upstream/main' into unicode-from-format…
philg314 Aug 2, 2022
99b0ebc
Add whatsnew
philg314 Aug 2, 2022
63e9afd
gh-93649: Split unicode tests from _testcapimodule.c
philg314 Aug 2, 2022
d70fa1f
Use built-in AssertionError
philg314 Aug 6, 2022
79a8138
Merge remote-tracking branch 'upstream/main' into unicode-from-format…
philg314 Aug 6, 2022
e8d0edf
Implement requested changes
philg314 Aug 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Implement requested changes
  • Loading branch information
@philg314
philg314 committed Aug 7, 2022
commit e8d0edfc16dbd365e59dc3d7013e9691b6d35390
2 changes: 1 addition & 1 deletion Misc/ACKS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,8 +608,8 @@ Marius Gedminas
Jan-Philip Gehrcke
Thomas Gellekum
Gabriel Genellina
Christos Georgiou
Philip Georgi
Comment thread
philg314 marked this conversation as resolved.
Christos Georgiou
Elazar (אלעזר) Gershuni
Ben Gertzfield
Nadim Ghaznavi
Expand Down
2 changes: 1 addition & 1 deletion Objects/unicodeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2482,7 +2482,7 @@ unicode_fromformat_arg(_PyUnicodeWriter *writer,
}
assert(len >= 0);

int negative = buffer[0]=='-'?1:0;
int negative = (buffer[0] == '-');
len -= negative;

precision = Py_MAX(precision, len);
Expand Down