Skip to content

gh-95132: Correctly relay *args and **kwds from sqlite3.connect to factory #95146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 9 commits into from
Jul 23, 2022
Merged

gh-95132: Correctly relay *args and **kwds from sqlite3.connect to factory #95146

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2c9e96f
Add test
erlend-aasland Jul 22, 2022
479959f
[alt 1] gh-95132: partially revert 185ecdc
erlend-aasland Jul 22, 2022
507e5ca
Add NEWS
erlend-aasland Jul 22, 2022
95296cb
Improve test
erlend-aasland Jul 22, 2022
b8ef03d
[alt 2] gh-95132: use vectorcall
erlend-aasland Jul 22, 2022
b144689
Add notes re docstrings
erlend-aasland Jul 22, 2022
bef0572
Further improve tests
erlend-aasland Jul 22, 2022
cf5da8e
Fix isolation_level default value
Jul 23, 2022
ca41429
Update Modules/_sqlite/module.c
Jul 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve test
  • Loading branch information
@erlend-aasland
erlend-aasland committed Jul 22, 2022
commit 95296cb66c758db921b78642d91ed9d51092c603
5 changes: 3 additions & 2 deletions Lib/test/test_sqlite3/test_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,11 @@ def test_connection_factory_relayed_call(self):
# gh-95132: keyword args must not be passed as positional args
class Factory(sqlite.Connection):
def __init__(self, *args, **kwargs):
kwargs['timeout'] = 42
kwargs["isolation_level"] = None
super(Factory, self).__init__(*args, **kwargs)

sqlite.connect(":memory:", factory=Factory)
con = sqlite.connect(":memory:", factory=Factory)
self.assertIsNone(con.isolation_level)


class CursorFactoryTests(unittest.TestCase):
Expand Down